Comments on: If Then Else Shorthand in C#

By: Mike K

Mike K — Wed, 15 Feb 2012 16:23:49 +0000

Sashi does have a point. In the following scenario the Thing1 property is nullable, and therefore does allow a null value. The tradition if/else works here but the shorthand version will give you an error.

public class Stuff
{
public Stuff( DataRow dr )
{
if( Convert.IsDBNull( dr["thing1"] ) )
{
Thing1 = null;
}
else
{
Thing1 = Convert.ToInt32( dr["thing1"] );
}

Thing2 = Convert.IsDBNull( dr["thing2"] ) ? null : dr["thing2"].ToString();
}

int? Thing1 { get; set; }
string Thing2 { get; set; }
}

By: G

Tue, 13 Sep 2011 16:41:45 +0000

The parenthesis doesn’t actually make any difference; it should still work with them on.

By: Bobhanzo

Bobhanzo — Thu, 28 Jul 2011 07:41:48 +0000

Edit:
I mean it’s:
Data[2] = min > 0 ? 0×00 : oxo1;

By: Bobhanzo

Bobhanzo — Thu, 28 Jul 2011 07:40:55 +0000

Im sure you found your answer already but for the next one who gets this problem:

Dont use the ( )

Just type:
Data[2] = (min > 0) ? 0×00 : oxo1;

By: Ruben

Ruben — Thu, 12 May 2011 11:51:01 +0000

How can I write this shorter?
if (min > 0)
{
Data[2] = 0×00;
}
else {
Data[2] = 0×01;
}
I Tried
Data[2] = (min > 0) ? 0×00 : oxo1;

The Data array is Byte and min is integer. It should not be a problem. but in the short form it is not working.
Any ideas?

By: Dusty Reagan

Dusty Reagan — Mon, 04 Oct 2010 00:00:29 +0000

Thanks for the clarification Tyler. I fixed the typo.

By: Tyler Cash

Tyler Cash — Sun, 03 Oct 2010 03:10:23 +0000

Shashi,
I typically do not reply to posts on any website whatsoever but your scenario may lead others to infer that the authors post is not a viable and effective option, where in fact it indeed is.
There are a couple problems with your posted scenario:
showtopEntries = reader["showTopentries"] == DbNull.Value ? null : Convert.ToInt32(reader["showTopEntries"])
1. I am assuming that you have declared showtopEntries as an Integer as you are converting one of the conditions to an Integer. Based on that assumption, you will not be able to implicitly assign a null value to an Integer as an Integer is a value type. One could assign null to a reference type such as a string. In C# a null value is the absence of anything and therefore not a value.
2. I realize that the author of this post has a typo within the declaration of the initial Integer, showTopeEntries where it should state showTopEntries. That said, C# is still a case sensitive language so if you mirrored the example above and remedied the typo, you will still need to ensure that the case is correct.
If you require an Integer as the result try the following scenario: int intShowTopEntries;
intShowTopEntries = reader["showTopEntries"] == DbNull.Value ? 0 : Convert.ToInt32(reader["showTopEntries"]);
If you require for example a string as the result try the following scenario: string ShowTopEntries;
ShowTopEntries = reader["showTopEntries"] == DbNull.Value ? null : reader["showTopEntries"].ToString();

By: Shashi

Shashi — Fri, 24 Sep 2010 14:49:43 +0000

It doesnt work in the followng scenario

showtopEntries = reader["showTopentries"] == DbNull.Value ? null : Convert.ToInt32(reader["showTopEntries"])

By: Style

Style — Fri, 29 Jan 2010 08:04:07 +0000

thanks =)

By: Janus007

Janus007 — Tue, 23 Dec 2008 12:37:10 +0000

or
showTopEntries = showTopEntries >= totalEntries ?? totalEntries